-
Notifications
You must be signed in to change notification settings - Fork 2
Bb2 4376 v3 changes #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but should this be gitignored or removed from this changeset? Was this change only generated because we installed from the local sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that can definitely be removed. This may have been in part because I had been trying to get yarn to work right between this and the SDK
yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for package-lock.json, should this be removed from the PR, or is this a necessary part of the change?
Changes to allow v3 functionality in sample client by using the updated SDK. Includes some extra console.log messages for debugging but could be removed.
JIRA Ticket:
BB2-4376
What Does This PR Do?
Changes for v3 functionality in a local version of the sample client
What Should Reviewers Watch For?
Any breaking changes or unexpected behavior with v2 or v3.
Validation
Validated by way of local auth